PlaylistV2 PoC - #39429
Draft
sangwoo108 wants to merge 1 commit into
Draft
Conversation
sangwoo108
commented
Aug 26, 2026
Collaborator
- Resolves
Contributor
📋 Code Owners Summary50 file(s) changed, 4 with assigned owners 2 team(s) affected: Owners and Their Files
|
| // that both paths happen to find. | ||
| class PlaylistNetworkMediaDetector final | ||
| : public content::WebContentsObserver, | ||
| public content::WebContentsUserData<PlaylistNetworkMediaDetector>, |
Contributor
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] Prefer dependency injection
References:
- https://chromium.googlesource.com/chromium/src/+/main/docs/chrome_browser_design_principles.md#structure_modularity
Source: https://github.com/brave/security-action/blob/main/assets/opengrep_rules/client/web-contents-user-data.yaml
Cc @goodov @cdesouza-chromium @bridiver
sangwoo108
force-pushed
the
sko/playlist-v2
branch
from
August 26, 2026 23:59
dbc6a97 to
318c074
Compare
Collaborator
|
Warning You have got a presubmit warning. Please address it if possible. Items: |
sangwoo108
force-pushed
the
sko/playlist-v2
branch
from
August 27, 2026 00:32
318c074 to
b17a479
Compare
sangwoo108
force-pushed
the
sko/playlist-v2
branch
from
August 27, 2026 00:58
b17a479 to
fbef3b8
Compare
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.