[Android] Implement bottom bar parity with bottom navigation controls - #39453
[Android] Implement bottom bar parity with bottom navigation controls#39453samartnik wants to merge 1 commit into
Conversation
samartnik
added
CI/skip-ios
![github-actions[bot]](https://avatars.githubusercontent.com/in/15368?s=60&v=4){kind=small}
| "../../brave/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkToolbarCoordinator.java", | ||
| "../../brave/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkUtils.java", | ||
| "../../brave/android/java/org/chromium/chrome/browser/bookmarks/BraveBookmarkUtilsDummySuper.java", | ||
| "../../brave/android/java/org/chromium/chrome/browser/bottombar/BraveBottomBarActionCoordinator.java", |
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] New source files should not be added to sources.gni. Please see https://github.com/brave/brave-core/blob/master/docs/gni_sources.md for details
Source: https://github.com/brave/security-action/blob/main/assets/opengrep_rules/client/java_sources_gni.yaml
Cc @brave/java-sources-gni-reviewers
There was a problem hiding this comment.
This is in line with upstream
| # depended on by the component it depends on. Its sibling in the same directory, | ||
| # BraveBottomBarCoordinator, is constructed from chrome_java instead and so | ||
| # lives in the //brave/browser/ui/android/bottombar:java target. | ||
| brave_bottombar_java_sources = [ "//brave/browser/ui/android/bottombar/java/src/org/chromium/chrome/browser/ui/bottombar/BraveBottomBarButtonManager.java" ] |
There was a problem hiding this comment.
reported by reviewdog 🐶
[opengrep] New source files should not be added to sources.gni. Please see https://github.com/brave/brave-core/blob/master/docs/gni_sources.md for details
Source: https://github.com/brave/security-action/blob/main/assets/opengrep_rules/client/java_sources_gni.yaml
Cc @brave/java-sources-gni-reviewers
There was a problem hiding this comment.
As it's explained in the comment we need this to avoid circular dependency
| its own would have to be depended on by the component it depends on. | ||
| regex: | ||
| re_pattern: |- | ||
| (android_library\("java"\) \{\n sources = \[.+?\n \]\n) |
There was a problem hiding this comment.
nit: this pins sources = [ to being the first line inside android_library("java") { at exactly two spaces of indent, so an upstream testonly/visibility/comment line landing before it breaks the rewrite for a reason unrelated to its purpose. Anchoring on the target and letting .*? absorb the rest (e.g. (android_library\("java"\).*?\bsources\s*=\s*\[.*?\])) is the shape PLSTR-004 asks for.
| "java/src/org/chromium/chrome/browser/ui/bottombar/BottomBarView.java", | ||
| "java/src/org/chromium/chrome/browser/ui/bottombar/BottomBarViewBinder.java", | ||
| ] | ||
| + sources += brave_bottombar_java_sources |
There was a problem hiding this comment.
It seems, now gn.add_sources is available - https://github.com/brave/brave-core/blob/master/docs/plaster.md#rewriters .
3 participants
Resolves brave/brave-browser#58448