QualName similar names, but are actually distinct types#64
Conversation
|
Sorry, what are you intending to fix here? Are you just reporting the issue? You submitted a pull request, but it doesn't address anything. |
|
The fix was upgrading the edition version to 2021, anything prior would result in two html5ever libraries with different versions. This would make using QualName incompatible, because the compiler would get confused between the type that Kuchikiki exports and the two html5ever libraries. And sorry for the 3 commits, these are here because I experimented with different dependency versions. |
Could you share an example project which illustrates how updating the edition affects the html5ever dependency resolution? I'm aware of the edition affecting the default feature merging behaviour, but that (a) doesn't affect dependency versions and (b) only applies to the root crate, not a library like kuchikiki. |
Original Branch
This issue also persists in the original repo when creating a new element.
The issue
Well, markup5ever and html5ever both have QualName, but html5ever just re-exports QualName from markup5ever.
And because kuchikiki keeps pulling the 0.26.0 version of html5ever, it's not compatible with newer projects that use anything above 0.26.0.