Skip to content

test: cover github-actions package rules via rule outcome engine - #199

Open
thypon wants to merge 1 commit into
tests/bdd-foundationfrom
tests/github-actions-rules
Open

test: cover github-actions package rules via rule outcome engine#199
thypon wants to merge 1 commit into
tests/bdd-foundationfrom
tests/github-actions-rules

Conversation

@thypon

@thypon thypon commented Aug 25, 2026

Copy link
Copy Markdown
Collaborator

What

  • features/github-actions-rules.feature: 6 scenarios over the github-actions rule matrix — digest disabled + 7d, old trusted-org pin/patch/minor → 14d + autoApprove + automerge, recent pin → 7d no automerge, untrusted org → manager-enable rule applies, npm digest unaffected
  • Step definitions evaluate merged rule outcomes through the pure matcher engine (applicableRules + mergeRuleOutcome: managers/updateTypes/packageNames glob prefixes/age constraints, later rule wins, matcher keys stripped)
  • PresetWorld.evaluateRuleInput wires it into cucumber

Why

The ga rules in default.json encode a decision matrix (manager × org trust × update type × current age). Scenario-table tests at the decision boundaries catch regressions an end-to-end validator can't see.

Stack

Stack #202, above #198, below #200#201. Merge after #198.

Verification

pnpm install --frozen-lockfile
pnpm typecheck && pnpm test:bdd   # 23 scenarios, 101 steps green

default.json gates github-actions updates behind a matrix of manager,
package, update type and current age. Scenarios evaluate merged rule
outcomes at the decision boundaries (7/14 day ages, trusted orgs,
digest vs pin) through the pure matcher in src/lib/rules.ts, extended
into the cucumber world as evaluateRuleInput.
@thypon
thypon force-pushed the tests/github-actions-rules branch from bf7af33 to 2bb3e10 Compare August 25, 2026 22:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment

Labels

None yet

Projects

None yet

Development

Successfully merging this pull request may close these issues.

1 participant