[WIP] rag: connecting nv-ingest to TJ #40
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aw632
approved these changes
Nov 19, 2024
services/APIService/main.py
Outdated
| app = FastAPI(debug=True) | ||
| app = FastAPI( | ||
| debug=True, | ||
| title="ARA API Service", |
There was a problem hiding this comment.
They want us to call it AIRA now for AI Research Assistant
services/APIService/main.py
Outdated
| @@ -643,6 +661,57 @@ async def delete_saved_podcast( | |||
| ) | |||
|
|
|||
|
|
|||
| @app.post("/rag") | |||
| async def rag( | |||
| payload: dict, | |||
There was a problem hiding this comment.
Nit: can we add typing for this payload instead of dict?
services/APIService/main.py
Outdated
| """ | ||
| with telemetry.tracer.start_as_current_span("api.rag") as span: | ||
| # Validate required fields | ||
| if not all(key in payload for key in ["query", "k", "job_id"]): |
There was a problem hiding this comment.
Pydantic typing would also remove this part
services/APIService/main.py
Outdated
| @@ -643,6 +661,57 @@ async def delete_saved_podcast( | |||
| ) | |||
|
|
|||
|
|
|||
| @app.post("/rag") | |||
| async def rag( | |||
There was a problem hiding this comment.
Nit: we should call this query_vector_db or something similar, since this endpoint isn't actually generating anything.
|
All good comments. Will address |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.