Multiple hosts support, try n2 #1987
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
charmander
requested changes
Oct 5, 2019
| "packet-reader": "1.0.0", | ||
| "pg-connection-string": "0.1.3", | ||
| "pg-native": "^3.0.0", |
There was a problem hiding this comment.
pg isn’t supposed to have a dependency on pg-native, since pg-native is optional.
| @@ -20,16 +20,16 @@ | |||
| "main": "./lib", | |||
| "dependencies": { | |||
| "buffer-writer": "2.0.0", | |||
| "connection-string": "^3.0.4", | |||
There was a problem hiding this comment.
connection-string follows a different spec from libpq. I think a PostgreSQL driver should stick with the libpq format.
|
Oh, not sure I can finish this in the near future. Sorry ;-( Todo:
Still not sure what is actually right to do with |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Closes #1470