-
-
Notifications
You must be signed in to change notification settings - Fork 1.3k
Change instanceof(Date) to util.types.isDate(Date) #2862
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Open
Srayman
wants to merge
7
commits into
brianc:master
Choose a base branch
from
Srayman:master
base: master
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 3 commits
Commits
Show all changes
7 commits
Select commit
Hold shift + click to select a range
d544e07
change instanceof to isDate
Srayman d3749de
use both methods to check for valid Date
Srayman 91c6969
add test for PR 2862
Srayman fbd2138
use only isDate(date) in place of instanceof Date
Srayman c2efeba
Merge branch 'master' into #2862
charmander 2348a10
Extend compatibility of `isDate` use back to Node 8
charmander 69c7bfb
Clean up test
charmander File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,27 @@ | ||
'use strict' | ||
var helper = require('./../test-helper') | ||
var assert = require('assert') | ||
var util = require('util') | ||
var vm = require('vm'); | ||
|
||
const suite = new helper.Suite() | ||
|
||
suite.test('Handle date objects as Date', async (done) => { | ||
const date = new Date(); | ||
const dateObj = await vm.runInNewContext('new Date()'); | ||
assert(!(dateObj instanceof Date)) | ||
assert(util.types.isDate(dateObj)) | ||
const client = new helper.pg.Client() | ||
client.connect() | ||
|
||
await client.query('CREATE TEMP TABLE foo(bar TIMESTAMP, bar2 TIMESTAMP)') | ||
await client.query('INSERT INTO foo(bar, bar2) VALUES($1, $2)', [date, dateObj]) | ||
const results = await client.query('SELECT * FROM foo') | ||
const row = results.rows[0] | ||
const dbDate = row.bar | ||
const dbDateObj = row.bar2 | ||
assert.deepEqual(dbDate, date) | ||
assert.deepEqual(dbDateObj, dateObj) | ||
await client.end() | ||
done() | ||
}) |
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Uh oh!
There was an error while loading. Please reload this page.