Prevent concurrent uses of #ping and #close#1436
Open
byroot wants to merge 2 commits into
Open
Conversation
3 tasks
|
There has been a lot of CI changes to the repo recently, so maybe a rebase on master would cause CI to pass? |
It's disabled by default in MySQL 8.4, and entirely removed in 9.0
Contributor
Author
|
Looks like it's worse after a rebase. |
byroot
force-pushed
the
ping-close-lock
branch
3 times, most recently
from
c07489d to
10ccf8b
Compare
|
But aren't all the test failures related to .close behavior now? I thought they were related to your changes. |
byroot
force-pushed
the
ping-close-lock
branch
4 times, most recently
from
6ee5137 to
ac574fa
Compare
Fix: brianmario#1433 Apply the same locking mecanism `#query` uses to these two methods.
Contributor
Author
|
Right, the test suite was actually riddled with concurrent closing of connections held by still live threads. I cleaned all that up. It's now green. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Fix: #1433
Apply the same locking mechanism
#queryuses to these two methods.