Don't use StringIO in benchmarks #162
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
StringIO seems to be absurdly slow, on the order of ten times slower than writing to a real IO (e.g. a file). Writing the output to the null device (/dev/null on Linux, NUL on Windows, etc.) should be much more reasonable for performance comparison. Results from `benchmark/encode.rb` on my machine, using `StringIO.new` and `File.open(File::NULL, 'w')`: | | StringIO | Null device | | ------------------------------------ | --------- | ----------- | | Yajl::Encoder#encode (to an IO) | 3.085176 | 0.683039 | | Yajl::Encoder#encode (to a String) | 0.526030 | 0.544032 | | JSON.generate | 1.380079 | 1.432082 | | Psych.to_json | 10.271588 | 10.016573 | | Psych::JSON::Stream | 9.238529 | 4.949283 | | ActiveSupport::JSON.encode | 10.817619 | 10.233585 |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
StringIO seems to be absurdly slow, on the order of ten times slower
than writing to a real IO (e.g. a file). Writing the output to the
null device (/dev/null on Linux, NUL on Windows, etc.) should be much more
reasonable for performance comparison.
Results from
benchmark/encode.rbon my machine, usingStringIO.newand
File.open(File::NULL, 'w'):