Fix type annotations in Python 3.9 #232
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
`TypeAlias` was introduced in 3.10.
bbguimaraes
commented
Jan 20, 2025
Comment on lines
-36
to
-38
| try: | ||
| from typing import Self | ||
| except ImportError: |
There was a problem hiding this comment.
Changing this because mypy complains about the ImportError:
$ env-3.9/bin/mypy --follow-imports skip --disable-error-code import-untyped bw2data/revisions.py
[…]
bw2data/revisions.py:37: error: Module "typing" has no attribute "Self" [attr-defined]
bw2data/revisions.py:37: note: Use `from typing_extensions import Self` instead
bw2data/revisions.py:37: note: See https://mypy.readthedocs.io/en/stable/runtime_troubles.html#using-new-additions-to-the-typing-module
[…]
Codecov ReportAll modified and coverable lines are covered by tests ✅
Additional details and impacted files@@ Coverage Diff @@
## main #232 +/- ##
==========================================
+ Coverage 83.24% 85.19% +1.94%
==========================================
Files 39 42 +3
Lines 3730 4471 +741
==========================================
+ Hits 3105 3809 +704
- Misses 625 662 +37 ☔ View full report in Codecov by Sentry. |
|
Thanks @bbguimaraes ! |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
TypeAliaswas introduced in 3.10.