Point to super/issues instead of zed/issues #89
Merged
Conversation
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jameskerr
approved these changes
Jan 16, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
tl;dr
This PR fixes links to GitHub Issues at old "zed" URLs that have started being flagged by the link checker as HTTP 404.
Details
For some reason the link checker has started flagging HTTP 404 for links to issues at the old
https://github.com/brimdata/zed/issuesURLs. GitHub's repo redirect logic is still in place and if I try to access such an issue URL in a browser it still makes it to the right place in the end, but indeed if I do a straightcurlto the same URL I just get a plain 404. I could burn time hacking with the link checker config to figure out if there's a magic config combo that might allow it to handle the redirect on its own, but it seems quicker to just fix the URLs.I did a test deployment of a build from this branch to a personal staging site and it ran clean through a link checker.