True epoch stats #248
Merged
True epoch stats #248
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
ndiamant
suggested changes
Apr 29, 2020
ml4cvd/tensor_generators.py
Outdated
Comment on lines
188
to
194
| sum_squared = stats[k] | ||
| base_key = k.replace('sum_squared', '') | ||
| n = stats[f'{base_key}n'] | ||
| n_sum = stats[f'{base_key}sum'] | ||
| mean = n_sum/(eps+n) | ||
| logging.info(f'Continuous value \n{base_key} Mean:{mean:0.2f} Standard Deviation:{(sum_squared/n)-(mean*mean):0.2f} ' | ||
| f"Maximum:{stats[f'{base_key}max']:0.2f} Minimum{stats[f'{base_key}min']:0.2f}") |
There was a problem hiding this comment.
This is a little hard to follow. Maybe add some comments, or instead of iterating through stats, iterate through the continuous and categorical tmaps and create the keys from the tmap names.
ndiamant
approved these changes
May 1, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Addresses #216 thanks @ndiamant for guidance