[CTM-343] Filter out ai zones when getting compute zones#3549
Merged
lucymcnatt merged 4 commits intodevelopfrom Jan 28, 2026
Merged
[CTM-343] Filter out ai zones when getting compute zones#3549lucymcnatt merged 4 commits intodevelopfrom
lucymcnatt merged 4 commits intodevelopfrom
Conversation
lucymcnatt
requested review from
davidangb and
rjohanek
and removed request for
a team
git add core/src/main/scala/org/broadinstitute/dsde/rawls/dataaccess/HttpGoogleServicesDAO.scala
aednichols
approved these changes
Jan 28, 2026
LizBaldo
reviewed
Jan 28, 2026
| // `getZones()` returns the zones as resource urls of form `https://www.googleapis.com/compute/v1/projects/project_id/zones/us-central1-b", | ||
| // Hence split it by `/` and get last element of array to get the zone | ||
| zonesAsResourceUrls.map(_.split("/").last) | ||
| // the filter is due to new AI zones in these regions are not accepted by GCP Batch |
Contributor
There was a problem hiding this comment.
Nit: are not -> not being?
LizBaldo
approved these changes
Jan 28, 2026
Contributor
LizBaldo
left a comment
LizBaldo
left a comment
There was a problem hiding this comment.
LGTM. I have a small comment, and maybe add a unit test if it is easy?
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
3 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Ticket: https://broadworkbench.atlassian.net/browse/CTM-343
This is due to Google's addition of new AI zones, are not being recognized by Google Batch, see error below
Job gets no longer retryable information Batch Error: code - CODE_GCE_BAD_REQUEST, description - googleapi: Error 400: Invalid value for field 'resource.distributionPolicy.zones[1].zone': 'zones/us-central1-ai1a'. Zone (us-central1-ai1a) must be a valid zone in region us-central1., invalid, already retried 3 times, errors record CODE_GCE_BAD_REQUEST.This filters out ai zones when getting the compute zones for a region, which effectively means that when we submit a Batch request, this ai zone is excluded
PR checklist
model/, then you should publish a new officialrawls-modeland perform the corresponding dependency updates as specified in the README: