Update intgemm: optional AVX2 support #9
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
NB: windows builds are failing due to marian-nmt#765 unrelated to this PR. |
4 tasks
|
After having this PR applied into #6, some errors are gone, but not all. Please see #6 (comment) |
abhi-agg
approved these changes
Nov 18, 2020
|
@kpu Can we merge this change? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Updates intgemm to do a compiler test for AVX2 support. This is progress towards #5 and partly addresses compile errors in #6 .
Description
I've updated intgemm to add a compilation test for AVX2 support and macros to guard AVX2 usage.
How to test
Intentionally break the tests by adding garbage to files in
compile_testsChecklist