Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add args to create_proxy #34

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

sarahethompson
Copy link

Add the ability to send args to the POST method.

This enables the ability to set :trustAllServers => true.

Sample usage from ruby class:

@proxy_binary.create_proxy(80, { :trustAllServers => true })

@sarahethompson
Copy link
Author

Looks like the travis build is trying to unzip a non-existent browsermob-proxy binary.

@jarib
Copy link
Collaborator

jarib commented Nov 28, 2017

Thanks for the PR. I don't really maintain this library any more, and haven't touched the code since 2014.

I've made an attempt to fix the Travis build on master (upgraded the proxy, the dev dependency on selenium-webdriver to 3.7 and added Geckodriver), but I'm seeing several test failures that I don't have the capacity to look into right now.

If you (or anyone else) want to submit a PR that fixes the tests, I'll be happy to merge this PR and release a new gem.

@p0deje @titusfortner If you're interested in contributing a fix or take over the maintenance of this gem, let me know.

@p0deje
Copy link

p0deje commented Nov 28, 2017

I've never used BrowserMob so I'm definitely not the best person to maintain 😄

@sarahethompson
Copy link
Author

@jarib I can definitely look at the failed tests on travis.

@rriemann
Copy link

Any news?

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants