Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow logger to be lazy and converted on first use #14

Open
wants to merge 4 commits into
base: main
Choose a base branch
from

Conversation

mhenrixon
Copy link
Collaborator

The problem otherwise is that there is a load order problem in unique jobs. At least this way I can assign the logger regardless of how files are loaded.

@mhenrixon mhenrixon added the WIP Work in Progress label Oct 13, 2019
@mhenrixon mhenrixon requested a review from mberlanda October 13, 2019 20:54
@mhenrixon mhenrixon self-assigned this Oct 13, 2019
mberlanda
mberlanda previously approved these changes Oct 14, 2019
Copy link
Member

@mberlanda mberlanda left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Overall I trust you 😄
Would it be possible to add a test and/or an example of configuration with and without proc? This would make the change more documented

@mhenrixon
Copy link
Collaborator Author

If you have a look at the labels there is a wip label meaning this is work in progress. When I'm ready to have it reviewed I'll change that label to ready for review.

Usually, I change it when I've added tests and in some way or form verified that the code does what I expect it to do.

@mberlanda mberlanda dismissed their stale review October 15, 2019 10:13

still wip

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
WIP Work in Progress
Projects
None yet
Development

Successfully merging this pull request may close these issues.

None yet

2 participants