Migrate to Hatch and add a _legacy dependencies_ flavour #54
Conversation
…age generation documented and configured in CI
| !pyproject.toml | ||
| !README.md | ||
| !MANIFEST.in | ||
| !tests | ||
| !tox.ini | ||
| .dockerignore | ||
|
|
||
| # Reexclude protos | ||
| src/dataclay/proto |
There was a problem hiding this comment.
Won't it prevent dataClay running out of the box without having to generate protos?
There was a problem hiding this comment.
In theory, the [tool.hatch.build.hooks.custom] section of pyproject.toml is responsible of calling the compile_protos script on build time.
This "build time" should be:
- when doing a
pip install -e .for development - when doing a build process and generating the wheel
- when doing a
pip install git+https://also for development-adjacent
Am I wrong? Could you confirm if that's the case?
| with: | ||
| images: ${{ env.REGISTRY }}/${{ env.IMAGE_NAME }} | ||
| tags: | | ||
| type=edge,suffix=-legacydeps-py${{ matrix.python-version }},branch=main |
There was a problem hiding this comment.
This will create all tags with -legacydeps suffix. Is it correct?
There was a problem hiding this comment.
There are two sections, the id: meta and the id: legacy-deps-meta, and there are two build, build-and-push and build-and-push-legacy-deps. If I didn't do anything wrong, they should be separate images and we should obtain both the historical regular tags, and the one with -legacydeps that configure legacy dependencies. At least, that is what I intended.
| @@ -3,11 +3,11 @@ | |||
| # Define which Python versions to test with | |||
| PYPROJECT = nox.project.load_toml("pyproject.toml") | |||
| PYTHON_VERSIONS = nox.project.python_versions(PYPROJECT) | |||
There was a problem hiding this comment.
I get the following error when running nox:
AttributeError: module 'nox.project' has no attribute 'python_versions'
There was a problem hiding this comment.
That's a feature that was added on october lol.
Upgrade your nox. Given that nox is for developers only, I think that we can be a little bit early adopter on that 🙃
This branch uses Hatch as the build engine for the dataClay project, and that allows some fancy
--config-settings=LEGACY_DEPS=Truethat can be used to force a set of dependencies in the past (needed for compatibility with certain 3rd party libraries, AI frameworks, etc.).Given that I was already there, some cleanup on the build infrastructure and building protos during build process and streamlined docker image generation.