harden shim artifact validation - #41
Merged
Merged
Conversation
mcuadros
marked this pull request as ready for review
August 13, 2026 19:50
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
Hardens the optional native shim distribution path so a release artifact is
verified before publication and rejected deterministically when it does not
match the Go loader.
pointers;
libavdeviceremains an explicit optional capability.ffshim-manifest, which loads the exact final artifact, exercises safehelpers, and records its platform, FFmpeg family, contract, and SHA-256.
manifests again in the packaging job.
artifacts are now the only distribution channel for prebuilt shims.
Root cause
The repository's prebuilt shims could outlive changes to the C shim and the Go
loader. The previous workflow copied and uploaded them without loading the final
artifact or recording which FFmpeg family it belonged to.
Impact
Consumers fail closed with a diagnostic for an old, partial, tampered, or
wrong-family shim instead of reaching an incompatible native entry point.
Release archives identify the exact compatible artifact by platform and FFmpeg
major.
Validation
go test -count=1 ./...with local FFmpeg 9.0.1go test -short -count=1 ./...go vet ./...go test -race -count=1 ./internal/shim ./cmd/ffshim-manifestamd64/arm64, and Linux arm64
actionlint .github/workflows/ci.yml .github/workflows/build-shim.yml