Update scanning state of NeutrinoClient #974
Conversation
guggero
left a comment
guggero
left a comment
There was a problem hiding this comment.
Thanks for investigating! Makes sense as a short-term fix. But looks like we really need to refactor the re-scan logic at some point.
|
cc @yyforyongyu for review |
| case err := <-rescanErr: | ||
| if err != nil { | ||
| log.Errorf("Neutrino rescan ended with error: %s", err) | ||
| log.Errorf("Neutrino rescan ended with "+ |
There was a problem hiding this comment.
Do we know what the error is? What is the root cause?
There was a problem hiding this comment.
I am trying to obtain the logs from the user, but I think his node is generally working fine, my next step will be to let the user run the patch to see if that fixes the problem. But as Oliver and Laolu pointed out, this code part needs a refactor.
| // object will fail. | ||
| log.Info("Neutrino rescan finished") | ||
| s.clientMtx.Lock() | ||
| s.scanning = false |
There was a problem hiding this comment.
If we don't know what caused the rescan error, this will just create a new scan and then getting the same error?
There was a problem hiding this comment.
I am not sure, basically the link failed because the NewAddress (NotifiedReceived) returned an error when registering the wtclient for a specific link:
user at least reported that now the link is active, so seems like the backend still works correctly maybe some error failed the rescan and now we need to just restart it, but yeah let's hope we get more information from the user.
4 participants
Fixes: lightningnetwork/lnd#9468
@aakselrod could you take a look, I am not sure why the rescan process is not running for the user but we need to make sure we update the scan variable so that new rescans can be started.