Skip to content

removing console.log and fixing issues with Details Component #110

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

bbansalWolfPack
Copy link

Hello Brian

First of all thanks for the awesome tutorials, big fan.

While running the repo and going through tutorial, I found two issues for which I am creating this pull request.

  1. Console.log message in one component so thought to remove that
  2. In details component, when we make the api call to get details about a pet. I saw that some links returns 404 Error but the logic to handle them is missing. Even with 404, looks like api marks that promise a success because of which it shows in .then block where it fails as animal is undefined there. I added a catch block which sets loading to false and then the Error boundary takes over. Otherwise I was just seeing Loading on the screen which never gets to false.

Adding screenshot for the same.
Screen Shot 2020-08-16 at 10 29 14 AM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant