Fix settings not persisting #707
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The 0b11011111110100 in Switch.java was changed in one of the previous commits. This somehow causes the Event Name to be null for ToggleMenuModel's, which breaks persisting the changes.
2 tasks
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Changes
Fixes the BTTV settings not persisting if changed. It was caused because of a changed number in Switch.java in one of the previous commits. This somehow causes the Event Name to be null for ToggleMenuModel's, which breaks persisting the changes.
I changed the number back and also added an additional check for null values in SettingsPresenter (plus a slight change to the binding of the header to the MenuSection).
This fix might be worth a release ? Seeing as all the toggles in the BTTV settings menu are affected by this.
Checklist