refactor(mix_tailwinds): simplify code with Dart 3 patterns#847
Closed
leoafarias wants to merge 2 commits intofeature/mix-tailwindsfrom
Closed
refactor(mix_tailwinds): simplify code with Dart 3 patterns#847leoafarias wants to merge 2 commits intofeature/mix-tailwindsfrom
leoafarias wants to merge 2 commits intofeature/mix-tailwindsfrom
Conversation
- Extract common H1-H6 build logic into _buildHeading helper - Simplify _BorderAccum setters with compound assignment - Refactor _extractMargin to use pattern matching with switch - Apply Dart 3 case patterns in type checks throughout tw_parser - Convert shadow apply functions to switch expressions
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
Updated golden test images to match current rendering environment.
Collaborator
Author
|
Closing due to visual regressions detected in golden image comparison. |
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
_buildHeadinghelper (~100 lines reduced)_BorderAccumsetters with compound assignment_extractMarginto use pattern matching with switch expressiontw_parser.dartTest plan
flutter analyze)flutter test)dart format