Merged
Conversation
Ensure copyWith parameters are always optional by making their types nullable: SpecMixinBuilder now appends a '?' to parameter types that are not already nullable. Add comprehensive unit tests covering nullable and non-nullable fields, mixed types, complex types, list types, null-coalescing usage in the copyWith body, and prevention of double '??' suffix. The tests introduce test helpers (createTestFieldModel) and minimal fake implementations (_FakeDartType, _FakeFieldElement) to exercise FieldModel-driven code generation.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
Fixes an issue where
copyWithmethod parameters were not always optional, which could cause compilation errors when non-nullable types were used.Description
The code generator now ensures all
copyWithparameters are nullable (optional), regardless of whether the original field type is nullable or not. This is the expected behavior forcopyWithmethods, where you only provide the values you want to change.Changes
spec_mixin_builder.dart: ModifiedcopyWithparameter generation to append?to types that are not already nullablespec_mixin_builder_test.dart: Added comprehensive unit tests covering:BoxDecoration,AlignmentGeometry)??suffixReview Checklist
Additional Information (optional)
This fix ensures that generated
copyWithmethods follow Dart's idiomatic pattern where all parameters are optional. For example: