fix(mix_generator): Respect nullability in lerp and update deps#849
Merged
tilucasoli merged 5 commits intomainfrom Feb 6, 2026
Merged
fix(mix_generator): Respect nullability in lerp and update deps#849tilucasoli merged 5 commits intomainfrom
tilucasoli merged 5 commits intomainfrom
Conversation
Ensure copyWith parameters are always optional by making their types nullable: SpecMixinBuilder now appends a '?' to parameter types that are not already nullable. Add comprehensive unit tests covering nullable and non-nullable fields, mixed types, complex types, list types, null-coalescing usage in the copyWith body, and prevention of double '??' suffix. The tests introduce test helpers (createTestFieldModel) and minimal fake implementations (_FakeDartType, _FakeFieldElement) to exercise FieldModel-driven code generation.
Make LerpResolver choose the correct call operator for delegate-based lerp: use ?. for nullable fields and . for non-nullable fields (adds an isNullable check). Update unit tests to cover both nullable and non-nullable delegate cases. Relax and adjust dependency ranges in packages/mix_generator/pubspec.yaml for analyzer, build, source_gen, build_config, collection and dart_style to improve compatibility. Remove analyzer from the root pubspec dependencies.
|
To view this pull requests documentation preview, visit the following URL: Documentation is deployed and generated using docs.page. |
Contributor
|
The latest updates on your projects. Learn more about Vercel for GitHub.
|
…/mix into fix/optional-lerp-resolver
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Related issue
N/A
Description
This PR fixes the LerpResolver to correctly handle nullable vs non-nullable fields when generating lerp code, and makes copyWith parameters properly optional. Additionally, it relaxes dependency constraints for better compatibility.
Changes
LerpResolver nullability fix:
?.operator for nullable fields ($name?.lerp(other?.$name, t)).operator for non-nullable fields ($name.lerp(other?.$name, t))copyWith optional parameters:
StringbecomeString?in copyWith signatureDependency updates (mix_generator):
analyzer,build,source_gen,build_config,collection, anddart_styleanalyzerfrom root pubspec.yamlTesting:
Review Checklist
Additional Information (optional)
The dependency version changes improve compatibility with different Flutter/Dart SDK versions while still maintaining the required functionality.
Made with Cursor