Fix subtle potential race/panic in a test #276
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emcfarlane
reviewed
Apr 10, 2024
emcfarlane
approved these changes
Apr 10, 2024
emcfarlane
approved these changes
Apr 10, 2024
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Apr 12, 2024
In a CI run, there was a weird panic from a test in which there was a race between the test function exiting and another goroutine trying to report an error using the function's `*testing.T` instance. This fixes that. CI run: https://github.com/bufbuild/protocompile/actions/runs/8606959743/job/23586468561?pr=275 Panic output: ``` panic: Fail in goroutine after TestPathological has completed goroutine 343 [running]: testing.(*common).Fail(0xc0001c7380) C:/hostedtoolcache/windows/go/1.[19](https://github.com/bufbuild/protocompile/actions/runs/8606959743/job/23586468561?pr=275#step:7:20).13/x64/src/testing/testing.go:824 +0xe5 testing.(*common).Fail(0xc0005104e0) C:/hostedtoolcache/windows/go/1.19.13/x64/src/testing/testing.go:818 +0x47 testing.(*common).Errorf(0xc0005104e0, {0xab612a?, 0x7[20](https://github.com/bufbuild/protocompile/actions/runs/8606959743/job/23586468561?pr=275#step:7:21)f40?}, {0xc0001f7fc0?, 0x644f85?, 0x0?}) C:/hostedtoolcache/windows/go/1.19.13/x64/src/testing/testing.go:941 +0x65 github.com/bufbuild/protocompile/parser.TestPathological.func1.1() D:/a/protocompile/protocompile/parser/parser_test.go:1011 +0x6b created by time.goFunc C:/hostedtoolcache/windows/go/1.19.13/x64/src/time/sleep.go:176 +0x32 FAIL github.com/bufbuild/protocompile/parser 1.189s ``` (cherry picked from commit 8785698)
kralicky
pushed a commit
to kralicky/protocompile
that referenced
this pull request
Apr 12, 2024
In a CI run, there was a weird panic from a test in which there was a race between the test function exiting and another goroutine trying to report an error using the function's `*testing.T` instance. This fixes that. CI run: https://github.com/bufbuild/protocompile/actions/runs/8606959743/job/23586468561?pr=275 Panic output: ``` panic: Fail in goroutine after TestPathological has completed goroutine 343 [running]: testing.(*common).Fail(0xc0001c7380) C:/hostedtoolcache/windows/go/1.[19](https://github.com/bufbuild/protocompile/actions/runs/8606959743/job/23586468561?pr=275#step:7:20).13/x64/src/testing/testing.go:824 +0xe5 testing.(*common).Fail(0xc0005104e0) C:/hostedtoolcache/windows/go/1.19.13/x64/src/testing/testing.go:818 +0x47 testing.(*common).Errorf(0xc0005104e0, {0xab612a?, 0x7[20](https://github.com/bufbuild/protocompile/actions/runs/8606959743/job/23586468561?pr=275#step:7:21)f40?}, {0xc0001f7fc0?, 0x644f85?, 0x0?}) C:/hostedtoolcache/windows/go/1.19.13/x64/src/testing/testing.go:941 +0x65 github.com/bufbuild/protocompile/parser.TestPathological.func1.1() D:/a/protocompile/protocompile/parser/parser_test.go:1011 +0x6b created by time.goFunc C:/hostedtoolcache/windows/go/1.19.13/x64/src/time/sleep.go:176 +0x32 FAIL github.com/bufbuild/protocompile/parser 1.189s ``` (cherry picked from commit 8785698)
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
In this CI run, there's a weird panic from a test where there is a race between the test function exiting and another goroutine trying to report an error using the function's
*testing.Tinstance:https://github.com/bufbuild/protocompile/actions/runs/8606959743/job/23586468561?pr=275
In case that link expires (or GitHub cleans up the log/output details at some point), here's the output:
So this awkward change attempts to prevent the above panic.