Make comma-list parsing really robust #403
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
reviewed
Jan 7, 2025
jhump
reviewed
Jan 9, 2025
experimental/parser/parse_decl.go
Outdated
| // | ||
| // If we don't do this, message will be interpreted as an | ||
| // expression. | ||
| return !first && t.Kind() == token.Ident |
There was a problem hiding this comment.
This might be worth a TODO since editions uses identifiers instead of strings for reserved field names. So this means that reserved foo, bar baz will treat baz as a new decl, which is less than ideal.
There was a problem hiding this comment.
Figured out a way to resolve this w/o affecting the happy path.
jhump
approved these changes
Jan 9, 2025
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds more diagnostics for comma-delimited list of types and expressions, and ensures that commas are optional pretty much everywhere for generating a valid AST, while at the same time diagnosing all missing and extraneous commas. This ensures a match with the behavior advertised in #393.
Includes a test that exercises various corner cases.
This PR also adds
Span.RuneRangeandSpan.Rune, to aid in constructing suggestion spans.