Factor ast.Slice out into its own package
#416
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
jhump
approved these changes
Jan 7, 2025
experimental/seq/seq.go
Outdated
|
|
||
| // Delete deletes the element at the given index. | ||
| // | ||
| // Should panic if idx < 0 or idx > Len(). |
There was a problem hiding this comment.
Suggested change
| // Should panic if idx < 0 or idx > Len(). | |
| // Should panic if idx < 0 or idx >= Len(). |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I plan to use this pattern when I implement the IR package, so having it not live in the AST package is a good idea.
I've also refactored the interfaces to be simpler, and to reduce the number of methods that actually need to be implemented: almost all types (except for
ast.TypeList) that were previously anast.Slicenow have an accessor for it.The
ast.Slice.Iterfunction has been dropped, and iteration is now done with dedicated iterators inseq.