Implement the legalizer #438
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
this contains all of the functions used in the legalizer as well as the recursive tree walk, but it does not contain the diagnostics, which will come in commits that follow.
Since open/close tokens are fused, when we set the `idx` for `NewCursorAt` for close tokens, we need to use the offset to set it to the open token.
Add a setter for brackets on `TypeList` and set them in the parser.
This PR adds basic text wrapping to diagnostic messages (except those attached to snippets) to avoid needing to wrap notes/helps by hand when writing diagnostics.
This PR also adds a test to exercise the corner case.
jhump
reviewed
Feb 21, 2025
There was a problem hiding this comment.
I've gone through all of your later commits. Thanks for making the changes -- this is looking really good.
But it looks like the later commits are cherry-picked from main. Please instead merge from main. It makes the commit list more clear for reviewers (and it would just be one commit in the branch to skip over instead of many).
experimental/parser/testdata/parser/method/incomplete.proto.stderr.txt
Outdated
Show resolved
Hide resolved
experimental/parser/testdata/parser/method/incomplete.proto.stderr.txt
Outdated
Show resolved
Hide resolved
internal/ext/iterx/iterx.go
Outdated
| @@ -170,3 +170,19 @@ func Join[T any](seq iter.Seq[T], sep string) string { | |||
| }) | |||
| return out.String() | |||
| } | |||
|
|
|||
| // Chain returns an iterator that calls a sequence of iterators in sequence. | |||
There was a problem hiding this comment.
I usually see this function called Flatten.
There was a problem hiding this comment.
I would have called it Flatten if it took an iterator of iterators.
jhump
approved these changes
Feb 28, 2025
experimental/parser/testdata/parser/method/incomplete.proto.stderr.txt
Outdated
Show resolved
Hide resolved
experimental/parser/testdata/parser/method/incomplete.proto.stderr.txt
Outdated
Show resolved
Hide resolved
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR adds the legalizer: a collection of diagnostics that follow parsing to eliminate and diagnose invalid constructs that the parser accepted in order the make progress.
This PR also adds a new
syntaxpackage for e.g.syntax.Proto2and other editions knowledge. It adds functions for classifyingpredeclared.Names and some newtaxa.Nouns for naming concepts in diagnostics relevant to the legalizer. Parsing is also tweaked in a few places to generate better diagnostics.