Skip to content

Commit

Permalink
Test fix.
Browse files Browse the repository at this point in the history
  • Loading branch information
CBenghi committed Apr 5, 2024
1 parent 0156687 commit 4cc55cb
Show file tree
Hide file tree
Showing 2 changed files with 10 additions and 2 deletions.
10 changes: 9 additions & 1 deletion ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs
Original file line number Diff line number Diff line change
Expand Up @@ -72,7 +72,15 @@ internal protected override Audit.Status PerformAudit(AuditStateInformation stat
{
var totalFilters = IfcTypeConstraint.Intersect(aF, rF);
if (IfcTypeConstraint.IsNotNullAndEmpty(totalFilters))
ret |= IdsErrorMessages.Report201IncompatibleClauses(logger, this, schemaInfo, "impossible match of types between applicability and requirements");
{
var appDesc = aF.ConcreteTypes.Count() > 5

Check warning on line 76 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.

Check warning on line 76 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.

Check warning on line 76 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.

Check warning on line 76 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.
? $"{aF.ConcreteTypes.Count()} types"
: $"{string.Join(", ", aF.ConcreteTypes)}";
var reqDesc = rF.ConcreteTypes.Count() > 5

Check warning on line 79 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.

Check warning on line 79 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.

Check warning on line 79 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.

Check warning on line 79 in ids-lib/IdsSchema/IdsNodes/IdsSpecification.cs

View workflow job for this annotation

GitHub Actions / build (Release)

Dereference of a possibly null reference.
? $"{rF.ConcreteTypes.Count()} types"
: $"{string.Join(", ", rF.ConcreteTypes)}";
ret |= IdsErrorMessages.Report201IncompatibleClauses(logger, this, schemaInfo, $"impossible match of types between applicability ({appDesc}) and requirements ({reqDesc})");
}
}
}
}
Expand Down
2 changes: 1 addition & 1 deletion ids-tool.tests/IfcPredefinedPropertiesTests.cs
Original file line number Diff line number Diff line change
Expand Up @@ -94,7 +94,7 @@ public void IfcPropertyNameCoherenceAcrossSchemas()
unexpectedMeasureTypes++;
}
}
var expectedCount = 526;
var expectedCount = 587;
unexpectedMeasureTypes.Should().Be(expectedCount, $"{expectedCount} is the count of acknowledged variations");
}
}
Expand Down

0 comments on commit 4cc55cb

Please sign in to comment.