Updated Schema version parsing to handle both IDS1.0 and pre-release values for IFC4x3 #36
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…string value. Note we can't switch entirely over to IFC4X3_ADD2 without breaking changes to the CodeGen meta-data which I'm avoiding for now. This change simply means we can round-trip IFC versions using the latest 4X3 schema moniker. Once we fix up the code-gen, 'IfcSchema4x3StringLegacy' can be removed
|
Fixes #35 |
|
Hello @andyward, |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note we can't switch entirely over to IFC4X3_ADD2 without breaking changes to the CodeGen meta-data which I'm avoiding for now. This change simply means we can round-trip IFC versions using the latest IFC4X3_ADD2 schema moniker. Once we fix up the code-gen, 'IfcSchema4x3StringLegacy' can be removed.