Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade to Pattern Lab 3 #153

Merged
merged 30 commits into from
Nov 23, 2018
Merged

Upgrade to Pattern Lab 3 #153

merged 30 commits into from
Nov 23, 2018

Conversation

james-nash
Copy link

@james-nash james-nash commented Oct 18, 2018

Closes #124

  • Migrates to Pattern Lab 3.
  • Removes BrowserSync tasks and dependency, as PL now has a built-in dev server

⚠️ Remember to run npm install when checking out this branch - the dependencies have changed!

Progress

  • Migrated dependencies to new PL3 packages
  • Updated PL Gulp tasks to use new PL
  • Update any issues / incompatibilities in our Mustache files
  • Investigate if we can (should?) still use BrowserSync or use PL3's built-in dev server
  • Fix any outstanding bugs / quirks

@james-nash james-nash added the WIP STATUS: Work in Progress - Do Not Merge. Useful for long-running PRs label Oct 18, 2018
@james-nash james-nash self-assigned this Oct 18, 2018
@james-nash
Copy link
Author

Our pattern library seems to build fine, but it outputs a load of warnings like this:

Could not replace height with 33 inside <svg role="img" class="{{styleModifier}}"{{#titleId}} aria-labelledby="{{titleId}}"{{/titleId}}{{#width}} width="{{width}}"{{/width}}{{#height}} height="{{height}}"{{/height}}>
  <use xlink:href="#buildit-logotype"></use>
</svg>

Most likely, they're related to us doing some funky pattern parameter stuff. Maybe it's no longer supported in PL3?

@c1rrus c1rrus added 🌟 enhancement TYPE: Indicates new feature requests infrastructure CATEGORY: Infrastructure related - e.g. updates to build process, tests, tooling, etc. and removed WIP STATUS: Work in Progress - Do Not Merge. Useful for long-running PRs labels Oct 25, 2018
@james-nash james-nash changed the title Upgrade to Pattern Lab 3 (WIP) Upgrade to Pattern Lab 3 Oct 26, 2018
@james-nash james-nash requested a review from danbull October 26, 2018 08:13
Copy link
Collaborator

@danbull danbull left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Minor comment, but the rest LGTM!

"patternExportDirectory": "./pattern_exports/",
"patternExportPatternPartials": [],
"serverOptions": {
"wait": 1000
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Just wondering what this does and why it's needed?

Copy link
Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Good spot!

I checked it out, according to the pattern lab docs, these are "live server"config options. It seems wait is an optional delay the server waits after changes, before reloading the browser(s).

I've tried removing the option and it seems to behave fine, so I'll commit that change now.

@james-nash james-nash merged commit f900bdb into develop Nov 23, 2018
@james-nash james-nash deleted the pl3-upgrade branch November 23, 2018 22:37
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
infrastructure CATEGORY: Infrastructure related - e.g. updates to build process, tests, tooling, etc. 🌟 enhancement TYPE: Indicates new feature requests
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants