-
Notifications
You must be signed in to change notification settings - Fork 6
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Upgrade to Pattern Lab 3 #153
Conversation
Our pattern library seems to build fine, but it outputs a load of warnings like this:
Most likely, they're related to us doing some funky pattern parameter stuff. Maybe it's no longer supported in PL3? |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Minor comment, but the rest LGTM!
patternlab-config.json
Outdated
"patternExportDirectory": "./pattern_exports/", | ||
"patternExportPatternPartials": [], | ||
"serverOptions": { | ||
"wait": 1000 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Just wondering what this does and why it's needed?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Good spot!
I checked it out, according to the pattern lab docs, these are "live server"config options. It seems wait
is an optional delay the server waits after changes, before reloading the browser(s).
I've tried removing the option and it seems to behave fine, so I'll commit that change now.
Closes #124
npm install
when checking out this branch - the dependencies have changed!Progress