add support for Go 1.25, drop 1.24, a few related fixes and tweaks#971
Merged
mvdan merged 5 commits intoburrowers:masterfrom Aug 30, 2025
Merged
add support for Go 1.25, drop 1.24, a few related fixes and tweaks#971mvdan merged 5 commits intoburrowers:masterfrom
mvdan merged 5 commits intoburrowers:masterfrom
Conversation
While strictly speaking it would be okay to leave Go 1.24 support in place for the time being, we are behind on a few tasks at the moment so it's best to keep the setup at master simpler for the next release. Go 1.25 already came out two weeks ago, and it seems to have been a fairly smooth release, so I don't suspect any end users will have trouble upgrading to it. Note that two changes were necessary for garble to work on Go 1.25.0. First, we stop deduplicating runtimeAndLinknamed with runtimeAndDeps. Otherwise, for GOOS=windows, internal/runtime/cgroup would be missing as it is a //go:linkname target from runtime on all platforms, but it is not transitively imported from runtime on GOOS=windows. Second, the testing/synctest package is now part of std, and it is a //go:linkname target from the testing package but not a transitive import from it. Teach appendListedPackages that, when loading all packages for a `go test` run, it should load the new testing/synctest package too. Fixes burrowers#968.
The behavior is the same, but now we track the dependency in go.mod via `go get -tool`, which is a better approach. While here, make a package loading error slightly clearer.
New packages in Go's "allowAsmABIPkgs" list caused failures in gogarble.txtar's use of `garble build std`.
As spotted by scripts/check-third-party.sh, it's possible to import the testing package without using `go test`, so our previous solution to only load testing/synctest when running `go test` was not enough. Add a regression test via stdimporter in gogarble.txtar.
Member
Author
|
Just one failure; I think I've fixed it now. |
luantak
approved these changes
Aug 30, 2025
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
2 participants
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
(see commit messages - please do not squash)
Fixes #968.