This repository has been archived by the owner on Mar 21, 2023. It is now read-only.
Upgrade to March Hare #27
Open
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
There was no guarantee that the messages would be evenly divided between the three buckets, but that was what the test was asserting. This version just checks that at least one bucket got at least one message – because the point of the test is just to show that custom demultiplexers can be used, not that the specific demultiplexer works.
It’s been here since the first commit, empty.
It’s been due for a while.
|
Was it really that easy. I looked at this a while back, but I guess I was fooled by the relation between consumers and subscriptions. The README still refers to hot-bunnies and should probably also be updated. Otherwise, everything looks good to me. |
|
Looks like I forgot to push the readme updates. |
|
I think it helps to be the one who wrote the subscription/consumer-things… |
|
This has been left for a long time but it still feels relevant to get done. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This upgrades to March Hare (neé HotBunnies) 2.7.
Most of MH is backwards compatible all the way to the version we were using (1.5), but I had to rewrite a few things around subscriptions that's been changed: there's no longer a separate subscription object, but the consumer has all the properties needed (and really, the consumer is the subscription). The base consumers that ship with MH are also different so I needed to upgrade Autobahns custom consumer to use another base class.