fix(segments): Calculate absolute_offset and Position properly
#593
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
stale
bot
added
stale
mnpw
reviewed
Apr 18, 2023
h3nill
commented
Apr 18, 2023
Comment on lines
+277
to
+287
| if self.active_segment().size() < self.max_segment_size as u64 { | ||
| Ok(Position::Done { | ||
| start, | ||
| end: (cursor.0, absolute_offset), | ||
| }) | ||
| } else { | ||
| Ok(Position::Done { | ||
| start, | ||
| end: (cursor.0 + 1, absolute_offset), | ||
| }) | ||
| } |
There was a problem hiding this comment.
if active_segment().size() >= self.max_segment_size on the next append to commitlog we will call apply_retention and new segment would be created.
2 tasks
|
@henil is the bug fix still required? most of the changes already existed in main branch, I resolved the merge conflicts, can you have a look at current state of PR and lmk if the changes are still required? if not required, can we close the PR? |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Type of change
Checklist:
cargo fmt