-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
chore(rumqttc): update to latest versions of rustls and friends #790
Conversation
This is blocked on |
Sent najamelan/ws_stream_tungstenite#15 to update |
Hey @qwandor , the PR to update can we please break down this PR into two separate PRs ( for rumqttc & rumqttd respectively )? would be better for review & merge. also, regarding some changes like removing trust_anchors, it would be helpful if you mention why this change was made in PR description! Thanks :) |
4eafa5f
to
af6f74e
Compare
Yep, updated it now.
Done, though you'll probably run into merge conflicts with
The method was renamed and does more of the work that we had to do manually before. |
oh didn't thought about it tbh, as I never encountered em so for 😅 . Reason for asking to separate em out is for maintainability. |
will review this PR in depth once we are done with #795 :) |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thanks for the PR! LGTM 👍
you were right about the merge conflicts in |
I've rebased and fixed the conflicts in Cargo.lock. |
Type of change
Checklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.