Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

chore(rumqttc): update to latest versions of rustls and friends #790

Merged
merged 1 commit into from
Feb 15, 2024

Conversation

qwandor
Copy link
Contributor

@qwandor qwandor commented Jan 29, 2024

Type of change

  • Breaking change (fix or feature that would cause existing functionality to not work as expected)

Checklist:

  • Formatted with cargo fmt
  • Make an entry to CHANGELOG.md if it's relevant to the users of the library. If it's not relevant mention why.

@qwandor qwandor marked this pull request as draft January 29, 2024 13:34
@qwandor
Copy link
Contributor Author

qwandor commented Jan 29, 2024

This is blocked on ws_stream_tungstenite updating to the latest version of async-tungstenite.

@qwandor
Copy link
Contributor Author

qwandor commented Jan 29, 2024

Sent najamelan/ws_stream_tungstenite#15 to update ws_stream_tungstenite. Once that's released this PR should be ready to go.

@swanandx
Copy link
Member

swanandx commented Feb 9, 2024

Hey @qwandor , the PR to update ws_stream_tungstenite is merged! so we should be unblocked right?

can we please break down this PR into two separate PRs ( for rumqttc & rumqttd respectively )? would be better for review & merge.

also, regarding some changes like removing trust_anchors, it would be helpful if you mention why this change was made in PR description!

Thanks :)

@qwandor qwandor force-pushed the rustls branch 3 times, most recently from 4eafa5f to af6f74e Compare February 9, 2024 11:54
@qwandor qwandor marked this pull request as ready for review February 9, 2024 11:55
@qwandor
Copy link
Contributor Author

qwandor commented Feb 9, 2024

Hey @qwandor , the PR to update ws_stream_tungstenite is merged! so we should be unblocked right?

Yep, updated it now.

can we please break down this PR into two separate PRs ( for rumqttc & rumqttd respectively )? would be better for review & merge.

Done, though you'll probably run into merge conflicts with Cargo.lock.

also, regarding some changes like removing trust_anchors, it would be helpful if you mention why this change was made in PR description!

The method was renamed and does more of the work that we had to do manually before.

@swanandx
Copy link
Member

swanandx commented Feb 9, 2024

Done, though you'll probably run into merge conflicts with Cargo.lock.

oh didn't thought about it tbh, as I never encountered em so for 😅 . Reason for asking to separate em out is for maintainability.

@swanandx
Copy link
Member

swanandx commented Feb 9, 2024

will review this PR in depth once we are done with #795 :)

@swanandx swanandx self-requested a review February 9, 2024 14:58
Copy link
Member

@swanandx swanandx left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Thanks for the PR! LGTM 👍

@swanandx
Copy link
Member

you were right about the merge conflicts in Cargo.lock! what would be the best way to fix them? I guess we can just sync up this with main and rebuilding Cargo.lock should fix it.

@qwandor
Copy link
Contributor Author

qwandor commented Feb 14, 2024

I've rebased and fixed the conflicts in Cargo.lock.

@swanandx swanandx changed the title Update to latest versions of rustls and friends chore(rumqttc): update to latest versions of rustls and friends Feb 15, 2024
@swanandx swanandx merged commit 09fd763 into bytebeamio:main Feb 15, 2024
3 checks passed
@qwandor qwandor deleted the rustls branch February 15, 2024 12:40
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants