-
Notifications
You must be signed in to change notification settings - Fork 266
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
rumqttc: Enable native tls TlsConnector
support.
#870
rumqttc: Enable native tls TlsConnector
support.
#870
Conversation
Considering that the |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Hopefully no one depends on TlsConfiguration
being Debug
, Transport
ain't so LGTM
Pull Request Test Coverage Report for Build 9561251742Warning: This coverage report may be inaccurate.This pull request's base commit is no longer the HEAD commit of its target branch. This means it includes changes from outside the original pull request, including, potentially, unrelated coverage changes.
Details
💛 - Coveralls |
Since we don't do much with the |
I just keep align with the implement for I saw the updates, that's fine, just accepted. |
use `TlsConnector` instead of `Builder`
Added wss (WebSocket Secure) support.
I found the issue |
It's approved and tests are green, is there any more thing I need to do to let it merged? BTW, is there any timeline for next rumqttc release and crate update? |
hey, thanks for your patience and reminder :) actually we got caught up with other work and so this was missed.
due to same reason of not having much bandwidth, can't commit to any specific date rn, but should be quite soon. |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Please move changes regarding wss from this PR to another
TlsConnector
support.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Post mentioned changes please open a separate PR to address native-tls support for websockets
Co-authored-by: Devdutt Shenoi <[email protected]>
Co-authored-by: Devdutt Shenoi <[email protected]>
Co-authored-by: Devdutt Shenoi <[email protected]>
Co-authored-by: Devdutt Shenoi <[email protected]>
Co-authored-by: Devdutt Shenoi <[email protected]>
Co-authored-by: Devdutt Shenoi <[email protected]>
OK, wss example removed. I'll create another PR for websocket changes on main right after this one is merged. |
Thanks. |
Type of change
Resolves #866.
New feature (non-breaking change which adds functionality)
Transport::tls_with_config
now acceptsnative_tls::TlsConnectorBuilder
instance as input, to customize optionsChecklist:
cargo fmt
CHANGELOG.md
if it's relevant to the users of the library. If it's not relevant mention why.