Skip to content

fix: adjust logging #970

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from
Open

fix: adjust logging #970

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
8e2c579
Change error_span instances to info_span
JacksonUtsch May 22, 2025
85bf172
cargo fmt
JacksonUtsch May 22, 2025
fa45ef5
Merge remote-tracking branch 'bytebeam/main'
JacksonUtsch Sep 24, 2025
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
7 changes: 4 additions & 3 deletions rumqttd/src/router/routing.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -232,7 +232,7 @@ impl Router {
}

fn events(&mut self, id: ConnectionId, data: Event) {
let span = tracing::error_span!("[>] incoming", connection_id = id);
let span = tracing::info_span!("[>] incoming", connection_id = id);
let _guard = span.enter();

match data {
Expand Down Expand Up @@ -542,7 +542,7 @@ impl Router {
};

let client_id = incoming.client_id.clone();
let span = tracing::error_span!("incoming_payload", client_id);
let span = tracing::info_span!("incoming_payload", client_id);
let _guard = span.enter();

// Instead of exchanging, we should just append new incoming packets inside cache
Expand All @@ -558,7 +558,8 @@ impl Router {
for packet in packets.drain(0..) {
match packet {
Packet::Publish(publish, properties) => {
let span = tracing::error_span!("publish", topic = ?publish.topic, pkid = publish.pkid);
let span =
tracing::info_span!("publish", topic = ?publish.topic, pkid = publish.pkid);
let _guard = span.enter();

let qos = publish.qos;
Expand Down
2 changes: 1 addition & 1 deletion rumqttd/src/server/broker.rs
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -452,7 +452,7 @@ impl<P: Protocol + Clone + Send + 'static> Server<P> {
protocol,
self.awaiting_will_handler.clone(),
)
.instrument(tracing::error_span!(
.instrument(tracing::info_span!(
"remote_link",
?tenant_id,
client_id = field::Empty,
Expand Down