Skip to content

chore(deps): update upstream wasm deps to *.227.1 #204

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Open
wants to merge 3 commits into
base: main
Choose a base branch
from

Conversation

vados-cosmonic
Copy link
Contributor

@vados-cosmonic vados-cosmonic commented Mar 19, 2025

This PR is blocked on merge of upstream orca PR:

thesuhas/orca#241

This PR is blocked on a newer release of js-component-bindgen

This PR updates the upstream ecosystem dependencies to *.227.1.

In addition to requiring an update to the co-dependent js-component-bindgen crate, some tests that previously shouldn't have worked (?) needed to be updated.

@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-upstream-to-227-1 branch from 235057c to 6c9cc04 Compare March 21, 2025 07:47
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-upstream-to-227-1 branch 2 times, most recently from 165da2f to 99f172d Compare April 28, 2025 18:51
@vados-cosmonic vados-cosmonic marked this pull request as ready for review April 28, 2025 18:51
@vados-cosmonic
Copy link
Contributor Author

vados-cosmonic commented Apr 28, 2025

Hey @tschneidereit this is also ready to go now, with releases in other upstream (and technically downstream) projects.

[EDIT] Spoke too soon here, I'm seeing failures in http-server which are new/unexpected after rebase to main, need to investigate.

Note Jco is waiting on a componentize-js release, but not because of these deps -- it's waiting for the other fixes, so this doesn't need to delay a release cycle!

@vados-cosmonic vados-cosmonic marked this pull request as draft April 28, 2025 20:27
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-upstream-to-227-1 branch 4 times, most recently from 11b369a to 2118800 Compare May 16, 2025 09:06
@vados-cosmonic vados-cosmonic marked this pull request as ready for review May 16, 2025 09:12
@vados-cosmonic vados-cosmonic marked this pull request as draft May 16, 2025 09:29
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-upstream-to-227-1 branch 2 times, most recently from dd17e00 to 14e2332 Compare May 19, 2025 11:44
@vados-cosmonic vados-cosmonic marked this pull request as ready for review May 19, 2025 11:46
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-upstream-to-227-1 branch 4 times, most recently from 1c4fdef to f26359a Compare May 19, 2025 13:56
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-upstream-to-227-1 branch from f26359a to f6fc0d6 Compare May 19, 2025 14:06
@vados-cosmonic
Copy link
Contributor Author

Note -- given the change to parser code underneath the updating of the upstream dependencies, the commits in this PR should likely trigger a breaking change for downstream consumers (existing WITs that were written against older versions of the upstream crates will no longer work)

In fitting with conventional commits, this recommendation is reflected in the commit title:

chore(deps)!: update upstream wasm deps to *.227.1

Signed-off-by: Victor Adossi <[email protected]>
@vados-cosmonic vados-cosmonic force-pushed the chore(deps)=update-upstream-to-227-1 branch from f6fc0d6 to 22d6d58 Compare May 19, 2025 14:20
This commit increases the budget for tests in weval -- while this
represents a regression, this test is way outside it's parameters and
requires upstream changes to weval to fix.

Performance improvements/maintenance work for weval is out of scope
for componentize-js.

Signed-off-by: Victor Adossi <[email protected]>
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant