Prototype a new Buffer trait.
#1290
Draft
+285
−37
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
SUPERCILEX
reviewed
Jan 25, 2025
There was a problem hiding this comment.
If we go with this approach, I feel like there's a pretty good chance compiler folks will improve the error messages for us if we file bug reports. The story around passing in a mutable array but needing a slice instead has annoyed me for quite some time (I usually just as_mut_slice everything). It was pretty confusing to figure out initially, so I'm sure better error messages would be welcome.
sunfishcode
force-pushed
the
sunfishcode/new-read
branch
from
2b47fd2 to
e455b94
Compare
sunfishcode
added
the
semver bump
SUPERCILEX
reviewed
Jan 31, 2025
sunfishcode
force-pushed
the
sunfishcode/new-read
branch
from
e455b94 to
cce9330
Compare
I'm experimenting with a `Buffer` trait similar to #908, however I've run into a few problems. See the questions in examples/new_read.rs for details.
`Extend` now returns a `usize` to make it easier to test for end-of-stream.
sunfishcode
force-pushed
the
sunfishcode/new-read
branch
2 times, most recently
from
8b4cee0 to
f2eaa94
Compare
sunfishcode
force-pushed
the
sunfishcode/new-read
branch
from
f2eaa94 to
2278976
Compare
|
Looking at our APIs, I think we'd want to consider adding uninit methods to roughly these methods (the filtering is not great, sorry): |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
I'm experimenting with a
Buffertrait similar to #908, however I've run into a few problems. See the questions in examples/new_read.rs for details.@notgull @SUPERCILEX