wasmtime serve: Allow inheriting sockets from system manager - #14294
Open
simolus3 wants to merge 5 commits into
Open
wasmtime serve: Allow inheriting sockets from system manager#14294simolus3 wants to merge 5 commits into
wasmtime serve: Allow inheriting sockets from system manager#14294simolus3 wants to merge 5 commits into
Conversation
simolus3
requested review from
alexcrichton and
pchickey
and removed request for
a team
September 7, 2026 20:56
bjorn3
reviewed
Sep 7, 2026
bjorn3
reviewed
Sep 7, 2026
alexcrichton
reviewed
Sep 8, 2026
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
This adds the
--listenfdoption towasmtime serve. When it's enabled andwasmtimeis launched from a systemd socket unit, we use the socket created by systemd instead of creating a new one. The main benefit of this is efficiency: Thewasmtimeprocess is only started when the first client connects. Additionally, this allows sandboxing the process in a private network namespace (since the only socket it will use is inherited).To test this, the systemfd utility may be convenient:
This also removes the old
-S listenfdoption: The only place using that option was a check that errors when it's set.Closes #14289. As suggested in that thread, I've also linked the used systemd protocol for this in a comment.