Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Rename exclude parameter in metafeatures.py methods #210

Open
JeremyRees opened this issue Nov 22, 2019 · 0 comments
Open

Rename exclude parameter in metafeatures.py methods #210

JeremyRees opened this issue Nov 22, 2019 · 0 comments

Comments

@JeremyRees
Copy link
Contributor

Now that we've added exclude_groups as a parameter on these methods, the name exclude should be made more specific, e.g., exclude_ids, to avoid confusion.

Because renaming the parameter is a backwards-incompatible change to the public API, this needs to wait until a major version change.
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
1 participant
@JeremyRees