Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use metafeature groups for filtering #204

Merged
merged 21 commits into from
Nov 23, 2019
Merged

Use metafeature groups for filtering #204

merged 21 commits into from
Nov 23, 2019

Conversation

JeremyRees
Copy link
Contributor

Resolves #195. In PR #192 the enum MetafeatureGroup was introduced for tagging metafeatures. This PR tags target-dependent metafeatures as such and leverages the new groups for filtering in Metafeatures.list_metafeatures() and Metafeatures.compute(), with appropriate new unit tests included.

@codecov-io
Copy link

codecov-io commented Nov 15, 2019

Codecov Report

Merging #204 into develop will increase coverage by 0.01%.
The diff coverage is 93.75%.

Impacted file tree graph

@@             Coverage Diff             @@
##           develop     #204      +/-   ##
===========================================
+ Coverage    92.23%   92.24%   +0.01%     
===========================================
  Files           13       13              
  Lines          747      761      +14     
===========================================
+ Hits           689      702      +13     
- Misses          58       59       +1
Impacted Files Coverage Δ
metalearn/metafeatures/landmarking_metafeatures.py 100% <ø> (ø) ⬆️
metalearn/metafeatures/simple_metafeatures.py 100% <ø> (ø) ⬆️
...metafeatures/information_theoretic_metafeatures.py 95.34% <ø> (ø) ⬆️
...talearn/metafeatures/decision_tree_metafeatures.py 100% <ø> (ø) ⬆️
metalearn/metafeatures/base.py 93.61% <100%> (ø) ⬆️
metalearn/metafeatures/metafeatures.py 95.55% <93.1%> (-0.18%) ⬇️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 55ca6bf...0ef67d7. Read the comment docs.

@epeters3 epeters3 self-requested a review November 20, 2019 16:36
@bjschoenfeld bjschoenfeld merged commit 54da320 into develop Nov 23, 2019
@bjschoenfeld bjschoenfeld deleted the grouping branch November 23, 2019 23:47
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Add Group Filtering to Metafeatures.compute API
4 participants