Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Use tfsec instead of DivvyCloud scan in CI #850

Closed
wants to merge 4 commits into from
Closed

Use tfsec instead of DivvyCloud scan in CI #850

wants to merge 4 commits into from

Conversation

GaryGSC
Copy link
Member

@GaryGSC GaryGSC commented Mar 2, 2023

No description provided.

@github-actions
Copy link

github-actions bot commented Mar 2, 2023

Terraform Plan:

will create 1 resource:

  • local_file - appspec_json

will update 2 resources:

  • aws_alb_listener - https
  • aws_alb_listener - test_listener

will replace (delete then create) 1 resource:

  • aws_ecs_task_definition - task_def

see details

@GaryGSC
Copy link
Member Author

GaryGSC commented Mar 3, 2023

This has some rough edges that need to be resolved upstream.

In this repo, we need to specify working_directory to point the action to the shared Terraform bits so that we get relevant results, but then the SARIF results are relative to that directory (when they need to be relative to the repo's root to play nicely with GHAS).

@GaryGSC GaryGSC closed this Mar 3, 2023
@GaryGSC GaryGSC deleted the tfsec-scan branch March 3, 2023 23:49
@GaryGSC
Copy link
Member Author

GaryGSC commented Mar 27, 2023

Refs: #350

@GaryGSC
Copy link
Member Author

GaryGSC commented Jul 12, 2023

#980 helps resolve some of the directory issues involved here.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

1 participant