Skip to content

Commit

Permalink
Merge pull request #24 from byu-oit/rds-sg
Browse files Browse the repository at this point in the history
Remove RDS sg
  • Loading branch information
Blake Morgan authored Apr 7, 2020
2 parents cbacf3a + abb75d9 commit 33f44bb
Show file tree
Hide file tree
Showing 3 changed files with 1 addition and 17 deletions.
3 changes: 1 addition & 2 deletions README.md
Original file line number Diff line number Diff line change
Expand Up @@ -10,7 +10,7 @@ This module retrieves some basic [ACS](https://github.com/byu-oit/aws-acs) infor

```hcl
module "acs" {
source = "github.com/byu-oit/terraform-aws-acs-info.git?ref=v2.0.0"
source = "github.com/byu-oit/terraform-aws-acs-info.git?ref=v2.1.0"
}
```
After defining the module you can then retrieve the information you need (see available [outputs](#output) below) using the interpolation syntax:
Expand Down Expand Up @@ -49,7 +49,6 @@ After defining the module you can then retrieve the information you need (see av
| certificate_virginia | [object](https://www.terraform.io/docs/providers/aws/d/acm_certificate.html#attributes-reference) | The default zone's ACM certificate for us-east-1 (needed by CloudFront, API Gateway, etc.) object |
| db_subnet_group_name | [object](https://www.terraform.io/docs/providers/aws/d/security_group.html) | The database subnet group name for RDS in the specified VPC object |
| ssh_rdp_security_group | [object](https://www.terraform.io/docs/providers/aws/d/security_group.html) | The security group to enable SSH/RDP access to resources in the specified VPC object |
| rds_security_group | [object](https://www.terraform.io/docs/providers/aws/d/security_group.html) | The security group for RDS clusters and instances in the specified VPC object |
| oracle_security_group | [object](https://www.terraform.io/docs/providers/aws/d/security_group.html) | The security group to enable Oracle access to resources in the specified VPC object |
| github_token | string | The token to use in CI/CD pipelines to fetch source code from GitHub (this if only available in certain AWS accounts) |

Expand Down
11 changes: 0 additions & 11 deletions main.tf
Original file line number Diff line number Diff line change
Expand Up @@ -114,17 +114,6 @@ data "aws_security_group" "ssh_rdp" {
}
}

data "aws_security_group" "rds" {
filter {
name = "vpc-id"
values = [data.aws_vpc.vpc.id]
}
filter {
name = "group-name"
values = ["*rds_security_group*"]
}
}

data "aws_security_group" "oracle" {
count = local.oracle_security_group_id != null ? 1 : 0
id = local.oracle_security_group_id
Expand Down
4 changes: 0 additions & 4 deletions output.tf
Original file line number Diff line number Diff line change
Expand Up @@ -57,10 +57,6 @@ output "ssh_rdp_security_group" {
value = data.aws_security_group.ssh_rdp
}

output "rds_security_group" {
value = data.aws_security_group.rds
}

output "oracle_security_group" {
value = local.oracle_security_group_id != null ? data.aws_security_group.oracle[0] : null
}
Expand Down

0 comments on commit 33f44bb

Please sign in to comment.