Scaling and instance sizing

[jvisker]

This change is to help improve our autoscaling and sizing. Here are the goals:

• Stop using defaults for sizing so that it is apparent in the applications what is happening.
• Have a better auto scaling defaults, while still requiring thought for each application.
• Switch to a new scaling policy type that AWS recommends and is more managed

[github-actions]

Terraform Plan:

will create 26 resources:

• aws_efs_file_system - my_efs
• aws_alb - alb
• aws_alb_listener - http_to_https
• aws_alb_listener - https
• aws_alb_listener - test_listener
• aws_alb_target_group - blue
• aws_alb_target_group - green
• aws_cloudwatch_log_group - container_log_group
• aws_cloudwatch_log_group - xray_log_group
• aws_codedeploy_app - app
• aws_codedeploy_deployment_group - deploymentgroup
• aws_ecs_cluster - new_cluster
• aws_ecs_service - service
• aws_ecs_task_definition - task_def
• aws_iam_policy - secrets_access
• aws_iam_role - task_execution_role
• aws_iam_role - task_role
• aws_iam_role_policy_attachment - secret_task_policy_attach
• aws_iam_role_policy_attachment - secrets_policy_attach
• aws_iam_role_policy_attachment - task_execution_policy_attach
• aws_iam_role_policy_attachment - xray_task_policy_attach
• aws_route53_record - a_record
• aws_route53_record - aaaa_record
• aws_security_group - alb-sg
• aws_security_group - fargate_service_sg
• local_file - appspec_json

see details

[yoshutch]

did you mean?

Suggested change

	value = var.autoscaling_config != null ? aws_appautoscaling_policy.default : null
	value = var.autoscaling_config != null ? var.autoscaling_config : aws_appautoscaling_policy.default

[jvisker]

No? Why would I return the variable?