Tighten the type restriction for getproperty
convenience functions
#34
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Sorry to raise this issue again @andrewning. I checked out the changes you mentioned in #33, and they do fix the problem I was seeing, but I'm getting errors with some fancy array packages that I use occasionally with CCBlade.jl. For example, on
master
right now, if I try to construct an OffsetArray of OperatingPoint structs:I get similar errors if I try to use a
Fill
array from the FillArrays.jl package. The fix I found was to restrict thegetproperty
convenience functions toVector
instead ofAbstractVector
. Also the code now checks for both theref
andsize
symbols, since those are AFIACT the only two fields that exist in the plainArray
Julia type.I added tests for creating OffsetArrays and FillArrays, FYI.