Skip to content

Commit

Permalink
updated CSS to include both margin and padding for footer columns (#441)
Browse files Browse the repository at this point in the history
* updated CSS to include both margin and padding for footer columns

* Updated the out of date browser message for IE
  • Loading branch information
kevin-larry-bauer authored and Gi60s committed Dec 12, 2018
1 parent b7354c4 commit 7131f35
Show file tree
Hide file tree
Showing 14 changed files with 24 additions and 22 deletions.
8 changes: 5 additions & 3 deletions components/byu-footer/byu-footer-common.scss
Original file line number Diff line number Diff line change
Expand Up @@ -16,12 +16,14 @@ $universityFooterLogoMobileWidth: 280px;

$universityFooterVerticalPadding: 21px;

$siteFooterHorizontalPadding: 8px;
$siteFooterHorizontalMargin: 8px;
$siteFooterTopPadding: 0;
$siteFooterBottomPadding: 50px;
$siteFooterPadding: $siteFooterTopPadding $siteFooterHorizontalPadding $siteFooterBottomPadding $siteFooterHorizontalPadding;

$siteFooterMobilePadding: 16px $siteFooterHorizontalPadding 0;
$footerHorizontalPadding: 16px;

$footerColumnMargin: 16px $siteFooterHorizontalMargin 0;
$footerColumnPadding: 0 16px;

$large-siteFooterContentTopMargin: 33px;
$large-siteFooterContentBottomMargin: 40px;
Expand Down
6 changes: 3 additions & 3 deletions components/byu-footer/byu-footer.scss
Original file line number Diff line number Diff line change
Expand Up @@ -90,8 +90,8 @@

::slotted(*) {
flex-grow: 1;
margin: $siteFooterMobilePadding;
padding: 0 16px;
margin: $footerColumnMargin;
padding: $footerColumnPadding;
}

::slotted(*:last-child) {
Expand All @@ -114,7 +114,7 @@
}
}

$calcSubtractWidth: ($siteFooterHorizontalPadding) * 2;
$calcSubtractWidth: ($siteFooterHorizontalMargin + $footerHorizontalPadding) * 2;

.university-footer {
font-size: 9px;
Expand Down
2 changes: 1 addition & 1 deletion components/byu-header/byu-header.js
Original file line number Diff line number Diff line change
Expand Up @@ -134,7 +134,7 @@ class BYUHeader extends HTMLElement {
container = document.createElement('div');
container.className = 'menu-ie11-outdated ie11-outdated-hidden';
container.innerHTML = '<div class="menu-ie11-outdated-label">' +
' You are using an out-dated browser. BYU support for this browser is ending. Please <a href="http://webcommunity.byu.edu/supported-browsers" target="_blank">download a new browser</a>.' +
' You are using an out-dated browser. BYU support for this browser has ended. Please <a href="http://webcommunity.byu.edu/supported-browsers" target="_blank">download a new browser</a>.' +
'</div>';

const closeButton = document.createElement('button');
Expand Down
2 changes: 1 addition & 1 deletion dist/byu-theme-components.css

Some generated files are not rendered by default. Learn more about how customized files appear on GitHub.

2 changes: 1 addition & 1 deletion dist/byu-theme-components.css.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/byu-theme-components.min.css.map

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/components-compat.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/components-compat.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/components-compat.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/components-compat.min.js.map

Large diffs are not rendered by default.

6 changes: 3 additions & 3 deletions dist/components.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/components.js.map

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/components.min.js

Large diffs are not rendered by default.

2 changes: 1 addition & 1 deletion dist/components.min.js.map

Large diffs are not rendered by default.

0 comments on commit 7131f35

Please sign in to comment.