fix: remove automatically setting background to white #531
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The documentation already specifies that the developer should take care to use FAFAFA for the background. Doing it for them interferes with switching between a dark and light theme.
|
@stuft2 I'm surprised that this hasn't been reviewed by anyone yet. It looks like you need to perform an audit fix or remove the audit check from the pipeline. Also, I assume that you tested this in the UI with varying background colors? |
|
Hey @Gi60s! Yes, tested it with a dark background color. Removing that style allowed me to toggle seamlessly between a light and dark byu theme. There's been some internal conversations expressing some concerns with how this might negatively impact users downstream if they aren't specifying the off-white bg color already as directed in the usage instructions. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Summary of Changes
What did you change? If this is a bug fix, how did you fix it?
The documentation already specifies that the developer should take care to use FAFAFA for the background. Doing it for them interferes with switching between a dark and light theme.
If this fixes styling, please include before and after screenshots!
Browser Testing
I have tested these changes in:
Add an x in all the boxes that apply. Please mark desktop and mobile
browsers separately.
Desktop Browsers
Mobile Browsers
We support the last two versions of Chrome, Firefox, Safari, and Edge.