Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Test against python 3.9 #226

Closed
wants to merge 3 commits into from
Closed

Test against python 3.9 #226

wants to merge 3 commits into from

Conversation

clbarnes
Copy link
Contributor

A very minor update to be pushed through the CI sausage machine.

@florisla
Copy link
Collaborator

Very nice, thanks! I put this on my list to review soon(*).

(*) Might not be really soon.

@clbarnes
Copy link
Contributor Author

clbarnes commented Aug 18, 2021

This is superceded by #229 , but I'll leave this open for the time being as it's a less drastic change.

@clbarnes
Copy link
Contributor Author

I reverted the 3.9 addition to that PR, and so will open a fresh one once that's merged.

Copy link
Collaborator

@florisla florisla left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Needs a rebase now that we use Github Actions.

@@ -22,7 +22,7 @@ commits and tags:
* works without any VCS, but happily reads tag information from and writes
commits and tags to Git and Mercurial if available
* just handles text files, so it's not specific to any programming language
* supports Python 3 and PyPy3
* supports non-EOL Python (>=3.6 at time of writing) and PyPy3
Copy link
Collaborator

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Any particular reason to stop testing 3.5? It's EOL at Python.org but some long-term-support distros might still support it.

Of course, enabling f-strings counts as a good reason ;-)

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Personal preference, I suppose! The more EOL it is, the more awkward development is; more supported versions means more tests to run, and so on. We can be part of the pressure encouraging people/distros to use modern, secure versions, rather than enabling those who don't want to. I am about to make a new PR to supersede this which also drops 3.6 (also EOL).

@clbarnes
Copy link
Contributor Author

Superseded by #242

@clbarnes clbarnes closed this Feb 26, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants