Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Feat/allow timespans in force up and downtime + fix everything #132

Open
wants to merge 13 commits into
base: main
Choose a base branch
from

Conversation

jonathan-mayer
Copy link
Member

@jonathan-mayer jonathan-mayer commented Mar 3, 2025

Motivation

Closes #120
blocked by #118

Changes

  • bump deps by overwriting controller runtime version to compatible one with keda (this should be automatically replaced by dependabot or go mod tidy once keda supports that version
  • remove tristatebools
  • exclude, force up/downtime allow timespans
  • add boolean timespans
  • remove unintended behavior during overlapping timespan periods
  • early return in getForcedScaling
  • allow force up/downtime to be overwritten to false in more specific layers
  • use correct log message when forced scaling set to false/inactive and no other scaling set
  • add/change some comments
  • ungroup exclude and exclude until
  • fix ignoring false/non-unset exclusion values
  • add a bunch of tests
  • update tests to use simpler booleanTimeSpans instead of computed timespans which resolve to true/false

Tests done

  • unit tests passed

TODO

@jonathan-mayer jonathan-mayer added the enhancement New feature or request label Mar 3, 2025
@jonathan-mayer jonathan-mayer self-assigned this Mar 3, 2025
@jonathan-mayer jonathan-mayer added the blocked A PR which is blocked by other Issues/PRs label Mar 3, 2025
@jonathan-mayer jonathan-mayer changed the title Feat/allow timespans in force up and downtime Feat/allow timespans in force up and downtime + fix everything Mar 4, 2025
Copy link
Collaborator

@samuel-esp samuel-esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Everythings seems ok to me, just check the couple of comments I made. That was a complex refactoring, well done Jonathan

@samuel-esp samuel-esp self-requested a review March 4, 2025 12:24
Copy link
Collaborator

@samuel-esp samuel-esp left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
blocked A PR which is blocked by other Issues/PRs enhancement New feature or request
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Allow timespans in force up-/downtime
2 participants